Add LogtailClient curl connection timeout and timeout #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.lock and example-project vendor dir
Closed
|
Hello @vzikmund, thank you for your contribution 🙌 Customizable timeouts definitely make sense to me and are an awesome addition for making logging more stable. I took the liberty of changing the unit from seconds to milliseconds (to allow finer control). Please take care when upgrading from your fork if you ended up changing the defaults in your application 🙏 I'll make sure to release the change in both 2.x and 3.x to keep things consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to experience with occasionally slow Logtail endpoint, I decided to add connection timeout and timeout parameters to cURL settings. Timeouts are optional and set to 5 seconds by default - it should be enough for ordinary behaviour.
I wasn't able to run
composer installbecause ofcomposer.lockfile, which was created with php8. My environment is running in php7.4 which sould be sufficient according to requirements incomposer.jsonfile. Therefore I removed unnecessarycomposer.lockfile. I also added requiredext-curlinto thecomposer.json.